2014-05-09 16:59 GMT+09:00 Dan Carpenter <dan.carpenter@xxxxxxxxxx>: > On Fri, May 09, 2014 at 10:38:43AM +0900, Daeseok Youn wrote: >> clean up checkpatch.pl warning: >> WARNING: please no spaces at the start of a line in >> >> Signed-off-by: Daeseok Youn <daeseok.youn@xxxxxxxxx> >> --- >> This patch includes cleanup for fixing line length. >> > > This patch is super hard to review. Your "line length" fixes include > moving variable declarations around, deleting comments, getting rid of > nonsense curly braces. Those are all great but the patch is over a > thousand lines long and it's difficult to review. Yes.. I knew that. And sorry about that. but I was really hard to separate this patch for fixing coding style. :-( When I replaced spaces with tabs, it has too many tabs so I cannot leave that lines on this patch.(and removed curly braces can solve my concern..) But I should do as your comment. > > If you just change spaces to tabs, that takes me 5 seconds to review > because I have scripts and email macros to do that. > > If you just delete the #if 0 blocks that also is easy to review in a > single patch. OK. I will make a patch for that. > > Just delete all the code that depends on #ifdef RLD_DUMP_BUFDATA because > that stuff is never set. I think developer can be set with "#define RLD_DUMP_BUFDATA" for debugging before building this module. OK. I will remove that. > > Please break this up into smaller patches and also write a better > changelog. OK. sorry I will try breaking this up into smaller patches. It need to take some time for this. :-) Thanks for review. Regards, Daeseok Youn. > > regards, > dan carpenter > _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
