From: Haiyang Zhang <haiyangz@xxxxxxxxxxxxx>
Date: Thu, 8 May 2014 13:41:33 -0700
> +static inline void netvsc_record_rx_queue(struct sk_buff *skb,
> + struct hv_netvsc_packet *packet,
> + struct net_device *ndev)
> +{
> +#ifdef CONFIG_SYSFS
> + skb_record_rx_queue(skb, packet->channel->
> + offermsg.offer.sub_channel_index %
> + ndev->real_num_rx_queues);
> +#endif
> +}
This is still fantastically gross, what is so unique about your
driver that it needs hacks like this? No other driver to my
knowledge does.
Figure out what it is that makes your driver so unique, and
try to make it conform to how other drivers handle these
features without SYSFS ifdef'ery instead.
I'm not applying this patch, sorry.
Thanks.
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
