On Wed, May 07, 2014 at 11:40:50PM -0700, Joe Perches wrote:
> On Thu, 2014-05-08 at 11:53 +0530, Adithya K wrote:
> > This is patch for fixing of minor coding style problems.
> []
> > diff --git a/drivers/staging/gdm72xx/gdm_qos.c b/drivers/staging/gdm72xx/gdm_qos.c
> []
> > @@ -229,6 +229,7 @@ static u32 extract_qos_list(struct nic *nic, struct list_head *head)
> > entry = list_entry(
> > qcb->qos_list[i].prev,
> > struct qos_entry_s, list);
> > +
> > list_move_tail(&entry->list, head);
>
> That one is a checkpatch defect.
>
> The list_entry( use is really ugly too
> with bad indentation on the following line.
>
> Look at the entire function:
>
> static u32 extract_qos_list(struct nic *nic, struct list_head *head)
> {
> struct qos_cb_s *qcb = &nic->qos;
> struct qos_entry_s *entry;
> int i;
>
> INIT_LIST_HEAD(head);
>
> for (i = 0; i < QOS_MAX; i++) {
> if (qcb->csr[i].enabled) {
> if (qcb->csr[i].qos_buf_count < qcb->qos_limit_size) {
> if (!list_empty(&qcb->qos_list[i])) {
> entry = list_entry(
> qcb->qos_list[i].prev,
> struct qos_entry_s, list);
> list_move_tail(&entry->list, head);
> qcb->csr[i].qos_buf_count++;
>
> if (!list_empty(&qcb->qos_list[i]))
> netdev_warn(nic->netdev,
> "Index(%d) is piled!!\n",
> i);
> }
> }
> }
> }
>
> return 0;
> }
>
> Please consider rewriting the function
> to reduce unnecessary indentation.
>
> Something like:
>
> static u32 extract_qos_list(struct nic *nic, struct list_head *head)
> {
> struct qos_cb_s *qcb = &nic->qos;
> int i;
>
> INIT_LIST_HEAD(head);
>
> for (i = 0; i < QOS_MAX; i++) {
> if (!qcb->csr[i].enabled ||
> qcb->csr[i].qos_buf_count >= qcb->qos_limit_size)
> continue;
>
> if (!list_empty(&qcb->qos_list[i])) {
You could flip this one around as well.
if (list_empty(&qcb->qos_list[i])
continue;
Move the rest in one indent level.
> struct qos_entry_s *entry;
>
> entry = list_entry(qcb->qos_list[i].prev,
> struct qos_entry_s, list);
> list_move_tail(&entry->list, head);
> qcb->csr[i].qos_buf_count++;
>
> if (!list_empty(&qcb->qos_list[i]))
> netdev_warn(nic->netdev, "Index(%d) is piled!!\n",
> i);
> }
> }
regards,
dan carpenter
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
