On Sat, May 3, 2014 at 4:15 PM, Christian Engelmayer <cengelma@xxxxxx> wrote: > Fix the error path when a cookie mismatch is detected. In that case the > function jumps to the exit label without setting the uninitialized, local > variable 'return_error'. Detected by Coverity - CID 201453. > > Signed-off-by: Christian Engelmayer <cengelma@xxxxxx> > --- > Compile tested and applies against branch staging-next of tree > git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git > --- > drivers/staging/android/binder.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/staging/android/binder.c b/drivers/staging/android/binder.c > index 1f5e249..ca1b0e3 100644 > --- a/drivers/staging/android/binder.c > +++ b/drivers/staging/android/binder.c > @@ -1529,6 +1529,7 @@ static void binder_transaction(struct binder_proc *proc, > proc->pid, thread->pid, > (u64)fp->binder, node->debug_id, > (u64)fp->cookie, (u64)node->cookie); > + return_error = BR_FAILED_REPLY; > goto err_binder_get_ref_for_node_failed; > } > ref = binder_get_ref_for_node(target_proc, node); > -- > 1.9.1 Acked-by: Arve Hjønnevåg <arve@xxxxxxxxxxx> _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
