On Sat, 3 May 2014 20:27:35 -0400, Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote: > On Thu, May 01, 2014 at 11:54:02PM +0200, Christian Engelmayer wrote: > > Fix potential leaks in the error paths of r8712_set_key(). In case the > > algorithm specific checks fail, the function returns without enqueuing > > or freeing the already allocated command and parameter structs. Use a > > centralized exit path and make sure that all memory is freed correctly. > > Detected by Coverity - CID 144370, 144371. > > > > Signed-off-by: Christian Engelmayer <cengelma@xxxxxx> > > --- > > Compile tested and applies against branch staging-next of tree > > git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git > > This doesn't apply either, and neither does one of your other patches, > what is going on? Greg, I am sorry that last weeks set of staging patches had problems. It is not my intention to waste Your time. I could reproduce the issue by running git am on my patches as received back from the mailing list. Most of the set failed as the mails were split incorrectly. I started rebasing the patches to the current staging-next and fixed my mail agents settings to generate no multipart, 7bit text/plain us-ascii. Thus the same set sent to myself applies now to a fresh clone of Your tree. git checkout -b integration-test origin/staging-next Branch integration-test set up to track remote branch staging-next from origin. Switched to a new branch 'integration-test' git am ./staging.mbox Applying: staging: binder: fix usage of uninit scalar in binder_transaction() Applying: staging: comedi: ii_pci20kc: fix usage of uninit scalar in ii20k_attach() Applying: staging: rtl8188eu: fix potential leak in rtw_set_key() Applying: staging: rtl8188eu: fix potential leak in rtw_wx_read32() Applying: staging: rtl8188eu: fix potential leak in update_bcn_wps_ie() Applying: staging: rtl8712: fix potential leaks in r8712_set_key() Applying: staging: rtl8723au: Remove unused pointer in rtw_wdev_free() Applying: staging: rtl8712: fix potential leak in r871x_wx_set_enc_ext() Applying: staging: silicom: Remove needless calls of get_status_port_fn() Applying: staging: silicom: Remove unused pointer in bypass_init_module() Applying: staging: vt6656: fix potential leak in vt6656_hostap_ioctl() Applying: staging: rtl8188eu: fix potential leak in rtw_wx_set_enc_ext() Applying: staging: rtl8188eu: fix potential leak in rtw_mp_QueryDrv() Applying: staging: rtl8188eu: fix potential leak in rtw_mp_SetRFPath() Applying: staging: rtl8188eu: fix potential leak in rtw_mp_pwrtrk() > Can you just refresh all of the outstanding patches you have sent me > that I have not applied and resend them? Of course. In case there are no objections or further hints, I will check the refreshed patches later this week when I have got a bit more time and will resend them. Regards, Christian _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
