Re: [PATCH] [staging/silicom] Fixing missing blank line after declarations

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, May 05, 2014 at 07:10:37PM +0200, Fernando Apesteguia wrote:
> On Mon, May 05, 2014 at 09:57:48AM -0700, Greg KH wrote:
> > On Mon, May 05, 2014 at 06:40:13PM +0200, Fernando Apesteguia wrote:
> > > Small fix to driver. If these patches are welcomed, more could come in the
> > > future.
> > > 
> > > Regards
> > 
> > > >From d8369cba0552c5ea5f4eadc750434e39785e042a Mon Sep 17 00:00:00 2001
> > > From: Fernando Apesteguia <fernando.apesteguia@xxxxxxxxx>
> > > Date: Mon, 5 May 2014 18:16:53 +0200
> > > Subject: [PATCH] [staging/silicom] Fixing missing blank line after
> > >  declarations
> > > 
> > > ---
> > >  drivers/staging/silicom/bpctl_mod.c |    1 +
> > >  1 file changed, 1 insertion(+)
> > 
> > They would be welcome if they were in a format I could apply them in :)
> > 
> > See Documentation/SubmittingPatches for the details on how to do this
> > properly.
> 
> I think this one is good.

What one?  This email, no, I can't take it.

The patch needs to be in a format that I do not need to edit by hand,
and you forgot the signed-off-by: line, which is described in the kernel
file I pointed you at.  Please read that file for what it means, and how
to properly format a patch for inclusion.

thanks,

greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux