On 29 April 2014 09:36, Ulf Hansson <ulf.hansson@xxxxxxxxxx> wrote: > On 29 April 2014 03:54, <micky_ching@xxxxxxxxxxxxxx> wrote: >> From: Micky Ching <micky_ching@xxxxxxxxxxxxxx> >> >> This reverts commit c42deffd5b53c9e583d83c7964854ede2f12410d. >> >> commit <mmc: rtsx: add support for pre_req and post_req> did use >> mutex_unlock() in tasklet, but mutex_unlock() can't used in >> tasklet(atomic context). The driver need use mutex to avoid concurrency, >> so we can't use tasklet here, the patch need to be removed. >> >> The spinlock host->lock and pcr->lock may deadlock, one way to solve the >> deadlock is remove host->lock in sd_isr_done_transfer(), but if using >> workqueue the we can avoid using the spinlock and also avoid the problem. >> >> Signed-off-by: Micky Ching <micky_ching@xxxxxxxxxxxxxx> > > Acked-by: Ulf Hansson <ulf.hansson@xxxxxxxxxx> Hi Lee, Would you mind to pick this up and send it for 3.15 fixes? The other revert "[PATCH 1/2] mmc: rtsx: Revert "mmc: rtsx: modify error handle and remove smatch warnings", needs to go through the mmc tree. Kind regards Uffe _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
