Re: [patch] staging: rtl8723au: fix some confusing indenting

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Dan Carpenter <dan.carpenter@xxxxxxxxxx> writes:
> The break and the "unknown++" are at the same indent level so my static
> checker complains.  The if statement should be indented more.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>

Urgh yes, that should be cleaned up!

Acked-by: Jes Sorensen <Jes.Sorensen@xxxxxxxxxx>

>
> diff --git a/drivers/staging/rtl8723au/core/rtw_mlme_ext.c b/drivers/staging/rtl8723au/core/rtw_mlme_ext.c
> index eb7b98e..4ad80e7 100644
> --- a/drivers/staging/rtl8723au/core/rtw_mlme_ext.c
> +++ b/drivers/staging/rtl8723au/core/rtw_mlme_ext.c
> @@ -1235,8 +1235,8 @@ static int rtw_validate_frame_ies(const u8 *start, uint len)
>  		case WLAN_EID_ERP_INFO:
>  		case WLAN_EID_EXT_SUPP_RATES:
>  		case WLAN_EID_VENDOR_SPECIFIC:
> -		if (rtw_validate_vendor_specific_ies(pos, elen))
> -			unknown++;
> +			if (rtw_validate_vendor_specific_ies(pos, elen))
> +				unknown++;
>  			break;
>  		case WLAN_EID_RSN:
>  		case WLAN_EID_PWR_CAPABILITY:
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux