On Wednesday, April 30, 2014 2:13 AM, Ian Abbott wrote: > On 2014-04-29 20:59, H Hartley Sweeten wrote: >> Remove some unnecessary pacer divisor calculations. The divisors are calculated >> as part of the (*do_cmdtest) and don't need done in the (*do_cmd). >> >> Remomove the older, unused, divisor calc functions in 8253.h to avoid any >> confusion. >> >> Remove some unnecessary private data members in a couple drivers and the >> addi_common.h header. >> >> Tidy up hwdrv_apci3120 a bit. >> >> Fix a couple 8254 timer programming issues. As Ian Abbott pointed out, >> the i8254_load() function does not use the I8254_MODE* defines. Convert >> all drivers to use the i8254_set_mode()/i8254_write() sequence instead. >> >> v2: Fix some i8254_load() issued pointed out by Ian Abbott in patches >> 01, 02, 03, and 05. >> Add a couple new patchs (24 thru 32) to fix/clarify the remaining >> i8254_load() issues. >> >> H Hartley Sweeten (32): [snip] > Looks good! > > As a side node, I wonder if it's worth stripping out those `| > I8254_BINARY` bits as it's basically 'OR'ing with zero anyway. I like the I8254_BINARY, it documents the mode that the counter is used in. But, if you want to strip them out... BTW, I noticed that the i8254_set_mode() helpers have a slight "bug". if (mode > (I8254_MODE5 | I8254_BINARY)) return -1; This test will not allow the mode (I8254_MODE5 | I8254_BCD). Nothing uses it right now, and it's a bit silly to use BCD counting anyway. But... > Reviewed-by: Ian Abbott <abbotti@xxxxxxxxx> Thanks, Hartley _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
