We have two options: 1) Do we risk introducing new truncation bugs. 2) Do we risk breaking the driver because we didn't catch every truncation bug. Truncation bugs here are very low impact and probably no one would even notice. That's how not worried I am about truncation bugs in this context. It's also unlikely that we will introduce any new truncation bugs. Breaking the driver is very serious. But on the other hand as soon as you proposed introducing an -EINVAL, I reviewed the driver and found the places which would break when the code was changed. As a result of my review then the likely hood of breakage is now low. In other words both options are probably fine. If someone is able to test the -EINVAL change then I would be happy to have it. regards, dan carpenter _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
