On 2014-04-28 19:53, H Hartley Sweeten wrote:
Remove some unnecessary pacer divisor calculations. The divisors are calculated as part of the (*do_cmdtest) and don't need done in the (*do_cmd). Remomove the older, unused, divisor calc functions in 8253.h to avoid any confusion. Remove some unnecessary private data members in a couple drivers and the addi_common.h header. Tidy up hwdrv_apci3120 a bit. H Hartley Sweeten (23): staging: comedi: cb_pcidas: don't calc ai pacer divisors twice staging: comedi: cb_pcidas: don't calc ao pacer divisors twice staging: comedi: das16m1: don't calc pacer divisors twice staging: comedi: das1800: refactor Step 4 of das1800_ai_do_cmdtest() staging: comedi: das1800: don't calc pacer divisors twice staging: comedi: 8253.h: rename i8253_cascade_ns_to_timer_2div() staging: comedi: 8253.h: remove the unused i8253_cascade_ns_to_timer_*() staging: comedi: adl_pci9111: tidy up (*do_cmdtest) Step 4 staging: comedi: addi_apci_2032: tidy up cmd use in apci2032_interrupt() staging: comedi: amplc_pci224: remove 'ai_stop_continuous' from private data staging: comedi: amplc_pci230: remove 'ai_continuous' from private data staging: comedi: amplc_pci230: remove 'ao_continuous' from private data staging: comedi: addi_common.h: remove 'ui_AiFlags' from private data staging: comedi: addi_common.h: remove 'ui_AiScanLength' from private data staging: comedi: addi_common.h: remove 'pui_AiChannelList' from private data staging: comedi: addi_common.h: remove 'ui_AiTimer0' from private data staging: comedi: addi_common.h: remove 'ui_AiTimer1' from private data staging: comedi: addi_common.h: remove 'ui_AiDataLength' from private data staging: comedi: addi_common.h: remove 'ui_AiNbrofScans' from private data staging: comedi: addi_common.h: remove 'b_AiContinuous' from private data staging: comedi: hwdrv_apci3120: cmd->convert_src is always TRIG_TIMER staging: comedi: hwdrv_apci3120: fix 'b_AiCyclicAcquisition' usage staging: comedi: hwdrv_apci3120: remove clearing of 'b_OutputMemoryStatus' drivers/staging/comedi/drivers/8253.h | 105 +------------ .../staging/comedi/drivers/addi-data/addi_common.h | 10 +- .../comedi/drivers/addi-data/hwdrv_apci3120.c | 163 +++++++-------------- drivers/staging/comedi/drivers/addi_apci_2032.c | 20 +-- drivers/staging/comedi/drivers/adl_pci9111.c | 38 ++--- drivers/staging/comedi/drivers/amplc_pci224.c | 21 +-- drivers/staging/comedi/drivers/amplc_pci230.c | 47 ++---- drivers/staging/comedi/drivers/cb_pcidas.c | 49 +++---- drivers/staging/comedi/drivers/das16m1.c | 42 ++---- drivers/staging/comedi/drivers/das1800.c | 152 ++++++------------- 10 files changed, 190 insertions(+), 457 deletions(-)
Patches 01, 02, 03 and 05 have a little bug in the calls to i8254_load(). Patches 04, 06-23 look okay and don't seem to depend on the other patches. Reviewed-by: Ian Abbott <abbotti@xxxxxxxxx> for patches 04, 06-23. -- -=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@xxxxxxxxx> )=- -=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587 )=- _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
