What happened with this. My guess is that the code is buggy and curly
braces were intended but I'm not confident enough to submit that patch
myself.
regards,
dan carpenter
On Fri, Mar 28, 2014 at 02:27:56AM +0300, Dan Carpenter wrote:
> Hello Micky Ching,
>
> The patch fa590c222fba: "staging: rts5208: add support for rts5208
> and rts5288" from Nov 12, 2013, leads to the following static checker
> warning:
>
> drivers/staging/rts5208/rtsx_chip.c:107 rtsx_enable_bus_int()
> warn: add curly braces?
>
> drivers/staging/rts5208/rtsx_chip.c
> 80 void rtsx_enable_bus_int(struct rtsx_chip *chip)
> 81 {
> 82 u32 reg = 0;
> 83 #ifndef DISABLE_CARD_INT
> 84 int i;
> 85 #endif
> 86
> 87 reg = TRANS_OK_INT_EN | TRANS_FAIL_INT_EN;
> 88
> 89 #ifndef DISABLE_CARD_INT
> 90 for (i = 0; i <= chip->max_lun; i++) {
> 91 RTSX_DEBUGP("lun2card[%d] = 0x%02x\n", i, chip->lun2card[i]);
> 92
> 93 if (chip->lun2card[i] & XD_CARD)
> 94 reg |= XD_INT_EN;
> 95 if (chip->lun2card[i] & SD_CARD)
> 96 reg |= SD_INT_EN;
> 97 if (chip->lun2card[i] & MS_CARD)
> 98 reg |= MS_INT_EN;
> 99 }
> 100 if (chip->hw_bypass_sd)
> 101 reg &= ~((u32)SD_INT_EN);
> 102 #endif
> 103
> 104 if (chip->ic_version >= IC_VER_C)
> 105 reg |= DELINK_INT_EN;
> 106 #ifdef SUPPORT_OCP
> 107 reg |= OC_INT_EN;
> 108 #endif
>
> I assume there were curly braces intended so that the "reg |= OC_INT_EN;"
> was part of the if statement?
>
> 109 if (!chip->adma_mode)
> 110 reg |= DATA_DONE_INT_EN;
>
> regards,
> dan carpenter
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
