On Sun, Apr 27, 2014 at 06:19:59PM -0400, Oleg Drokin wrote: > On Apr 27, 2014, at 6:05 PM, One Thousand Gnomes wrote: > > >> Reviewed-by: John L. Hammond <john.hammond@xxxxxxxxx> > >> Reviewed-by: Isaac Huang <he.huang@xxxxxxxxx> > >> Signed-off-by: Oleg Drokin <oleg.drokin@xxxxxxxxx> > >> --- > >> drivers/staging/lustre/lnet/klnds/socklnd/socklnd.c | 4 ++-- > >> 1 file changed, 2 insertions(+), 2 deletions(-) > >> > >> diff --git a/drivers/staging/lustre/lnet/klnds/socklnd/socklnd.c b/drivers/staging/lustre/lnet/klnds/socklnd/socklnd.c > >> index 21d36ee..516f623 100644 > >> --- a/drivers/staging/lustre/lnet/klnds/socklnd/socklnd.c > >> +++ b/drivers/staging/lustre/lnet/klnds/socklnd/socklnd.c > >> @@ -829,14 +829,14 @@ ksocknal_select_ips(ksock_peer_t *peer, __u32 *peerips, int n_peerips) > >> best_npeers = iface->ksni_npeers; > >> } > >> > >> + LASSERT(best_iface != NULL); > >> + > > > > And this solves the problem how ??? > > This does not really solve anything. > Just moves the check to where it's actually going to do anything instead of the check being guarded by the NULL pointer access earlier on. > Could have been removed instead of course to just get an oops at all times. Then please just remove it, or, even better yet, fix it properly if there is a way that this pointer can be NULL. greg k-h _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
