> -----Original Message----- > From: Stephen Hemminger [mailto:stephen@xxxxxxxxxxxxxxxxxx] > Sent: Friday, April 25, 2014 5:43 PM > To: KY Srinivasan > Cc: davem@xxxxxxxxxxxxx; netdev@xxxxxxxxxxxxxxx; linux- > kernel@xxxxxxxxxxxxxxx; devel@xxxxxxxxxxxxxxxxxxxxxx; olaf@xxxxxxxxx; > apw@xxxxxxxxxxxxx; jasowang@xxxxxxxxxx; stable@xxxxxxxxxx > Subject: Re: [PATCH net-next 1/1] hyperv: Properly handle checksum offload > > On Fri, 25 Apr 2014 11:45:14 -0700 > "K. Y. Srinivasan" <kys@xxxxxxxxxxxxx> wrote: > > > @@ -474,6 +477,9 @@ static int netvsc_start_xmit(struct sk_buff *skb, > struct net_device *net) > > csum_info = (struct ndis_tcp_ip_checksum_info *)((void *)ppi + > > ppi->ppi_offset); > > > > + ip_hdr(skb)->check = 0; > > + csum_info->transmit.ip_header_checksum = 1; > > + > > if (net_trans_info & (INFO_IPV4 << 16)) > > csum_info->transmit.is_ipv4 = 1; > > else > > Linux doesn't need or want IP checksum offload. > It will not have any performance gain. Thanks Stephen; I will re-spin the patch and re-submit. K. Y _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel