On Fri, Apr 25, 2014 at 11:18:55PM +0530, RAGHAVENDRA GANIGA wrote:
> >From 7bdc654b12895889a539450528b52328901e6dc0 Mon Sep 17 00:00:00 2001
> From: Raghavendra Ganiga <ravi23ganiga@xxxxxxxxx>
> Date: Fri, 25 Apr 2014 23:11:22 +0530
> Subject: [PATCH] staging: comedi: fix coding style issues in comedi_fops.c
Why is all of this in the email? It shouldn't be here, git send-email
should not put it here.
>
> This is a patch to fix coding style
> warnings found by the checkpatch.pl tool
>
> Signed-off-by: Raghavendra Chandra Ganiga <ravi23ganiga@xxxxxxxxx>
> ---
> drivers/staging/comedi/comedi_fops.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/comedi/comedi_fops.c b/drivers/staging/comedi/comedi_fops.c
> index ea6dc36..0cd67d0 100644
> --- a/drivers/staging/comedi/comedi_fops.c
> +++ b/drivers/staging/comedi/comedi_fops.c
> @@ -1435,13 +1435,15 @@ static int __comedi_get_user_cmd(struct comedi_device *dev,
> s = &dev->subdevices[cmd->subdev];
>
> if (s->type == COMEDI_SUBD_UNUSED) {
> - dev_dbg(dev->class_dev, "%d not valid subdevice\n", cmd->subdev);
> + dev_dbg(dev->class_dev,
> + "%d not valid subdevice\n", cmd->subdev);
Why not just indent cmd->subdev instead of the whole string?
thanks,
greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
