On 24/04/14 19:14, Hartley Sweeten wrote:
On Thursday, April 24, 2014 4:27 AM, Ian Abbott wrote:
On 2014-04-24 00:07, H Hartley Sweeten wrote:
For aesthetics, rename this function so it has namespace associated
with the driver.
Change the parameters to the function. The 'mode' is really a flag to
load the counters and the divisors can be found in the private data.
To clarify the code and remove the magic numbers, use the 8253.h
helpers to set the timer mode and load the counters.
Signed-off-by: H Hartley Sweeten <hsweeten@xxxxxxxxxxxxxxxxxxx>
Cc: Ian Abbott <abbotti@xxxxxxxxx>
Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
---
drivers/staging/comedi/drivers/adv_pci1710.c | 42 +++++++++++++---------------
1 file changed, 20 insertions(+), 22 deletions(-)
[snip]
Okay, but probably needs changing to use different members of the device
private data to make sure it it loads the "live command" divisors rather
than the "command test" divisors.
Same comments as with PATCH 13/22. I think the core already handles
keeping the "live" command the "test" command separate.
To clarify, I mean it probably needs changing to use different members
as a consequence of fixing patch 17, which mixes yup the "live" and
"test" divisors.
--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@xxxxxxxxx> )=-
-=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587 )=-
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
