On 2014-04-17 07:33, Chase Southwood wrote:
The reset function for this driver is a bit of a mess; clean it up to ensure that it is functioning properly. Signed-off-by: Chase Southwood <chase.southwood@xxxxxxxxx> --- 2: *Changed order of register accesses for digital input registers back to original ordering. *Removed read of digital output status register and reordered the accesses of digital output registers to agree with the order found in addi_apci_2032. *Fixed copy/paste error in the counter register reset lines. 3: *Returned the reset callback to the boardinfo...oops. *Don't write APCI1564_DO_IRQ_REG (it's read only). *Don't clear counter reload values...counters have already been disabled. 4: Leave this in hwdrv_apci1564.c for now (it can be moved after separating this driver from addi_common.c) NB: This patch has been renamed in this version. It was previously known as "staging: comedi: addi_apci_1564: fixup and absorb apci1564_reset()" .../comedi/drivers/addi-data/hwdrv_apci1564.c | 24 ++++++++++++++-------- 1 file changed, 15 insertions(+), 9 deletions(-)
Looks okay and it addresses the concerns raised by Hartley. Reviewed-by: Ian Abbott <abbotti@xxxxxxxxx> -- -=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@xxxxxxxxx> )=- -=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587 )=- _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
