On Wednesday, April 16, 2014 10:52 AM, Ian Abbott wrote: >>> NAK. This will break existing libcomedi library function >>> comedi_get_generic_timed(), which will call the COMEDI_CMDTEST ioctl >>> with a NULL chanlist (but with chanlist_len > 1) and with start_src etc. >>> set to values other than TRIG_ANY. > [snip] >> Grrr... Missed that part in the comedilib __generic_timed() function. >> >> Probably best to drop this series for now and I'll dig back into it. > > FWIW, I think patches 20 onwards are okay! Ian, To minimize possible issues, I hope... I just posted a new series that just cleans up the step 5 pieces of the (*do_cmdtest) functions. These 15 patches were patches 5 thru 19 in this series. In all of them I now check that (cmd->chanlist && cmd->chanlist_len > 0) before calling the helper function that actually validates the chanlist. If these all appear fine I will proceed with the remaining cleanup I have for the async command support. Thanks, Hartley _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
