(adding John Stultz) On Wed, 2014-04-16 at 23:27 +0900, Seunghun Lee wrote: > This patch fix checkpatch.pl warnings and errors. [] > diff --git a/drivers/staging/android/uapi/binder.h b/drivers/staging/android/uapi/binder.h [] > @@ -169,7 +169,7 @@ struct binder_ptr_cookie { > struct binder_handle_cookie { > __u32 handle; > binder_uintptr_t cookie; > -} __attribute__((packed)); > +} __packed; If this .h file is meant to be a user-space #include, then it should not use the kernel specific __packed but keep the __attribute__((packed)) It does use __u32 though and that's generally kernel specific. John? Does any of these binder uapi files need a bit more sorting out? _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel