Re: [PATCH 05/49] staging: comedi: adl_pci9111: factor out step 5 of (*do_cmdtest)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2014-04-16 09:18, Dan Carpenter wrote:
On Tue, Apr 15, 2014 at 10:37:25AM -0700, H Hartley Sweeten wrote:
Step 5 of the (*do_cmdtest) validates that the chanlist, chan/range/aref/etc,
   ^^^^^^
Numbering the steps like this seems a bad idea in case we add another
step in the middle.

regards,
dan carpenter

Step 5 refers to the value returned by the function if it only gets to that stage of the tests. User-space code can check the return value from the COMEDI_CMDTEST ioctl to see how far it got, and the "step" values are pretty standardized.

--
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@xxxxxxxxx>        )=-
-=( Tel: +44 (0)161 477 1898   FAX: +44 (0)161 718 3587         )=-
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux