Subject is not correct format. Should be:
[PATCH] staging: android: uapi: fix coding style
On Wed, Apr 16, 2014 at 11:27:39PM +0900, Seunghun Lee wrote:
> This patch fix checkpatch.pl warnings and errors.
>
Patch does too many things at once. Split it up.
> Signed-off-by: Seunghun Lee <waydi1@xxxxxxxxx>
> ---
> drivers/staging/android/uapi/binder.h | 2 +-
> drivers/staging/android/uapi/ion.h | 20 +++++++++-----------
> 2 files changed, 10 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/staging/android/uapi/binder.h b/drivers/staging/android/uapi/binder.h
> index 904adb7..dba4cef 100644
> --- a/drivers/staging/android/uapi/binder.h
> +++ b/drivers/staging/android/uapi/binder.h
> @@ -169,7 +169,7 @@ struct binder_ptr_cookie {
> struct binder_handle_cookie {
> __u32 handle;
> binder_uintptr_t cookie;
> -} __attribute__((packed));
> +} __packed;
>
> struct binder_pri_desc {
> __s32 priority;
> diff --git a/drivers/staging/android/uapi/ion.h b/drivers/staging/android/uapi/ion.h
> index f09e7c1..36332dc 100644
> --- a/drivers/staging/android/uapi/ion.h
> +++ b/drivers/staging/android/uapi/ion.h
> @@ -20,19 +20,17 @@
> #include <linux/ioctl.h>
> #include <linux/types.h>
>
> -typedef int ion_user_handle_t;
This typedef is probably a valid use. Plus it looks to be part of the
user space API. Just leave it alone.
regards,
dan carpenter
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
