On 2014-04-16 07:57, Chase Southwood wrote:
We can remove this function from the boardinfo and move the code from hwdrv_apci1564.c into addi_apci_1564.c since it is the only reset function used by the driver. The function was also messy and failed to reset a few registers, these issues were fixed on the move. Signed-off-by: Chase Southwood <chase.southwood@xxxxxxxxx> --- 2: *Changed order of register accesses for digital input registers back to original ordering. *Removed read of digital output status register and reordered the accesses of digital output registers to agree with the order found in addi_apci_2032. *Fixed copy/paste error in the counter register reset lines. Ian, I addressed your comments as above. Chase
Looks good. Reviewed-by: Ian Abbott <abbotti@xxxxxxxxx> -- -=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@xxxxxxxxx> )=- -=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587 )=- _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel