Re: [PATCH 02/06] staging: dgap: Only read config file dgap.conf once

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 04/14/2014 11:49 AM, Greg Kroah-Hartman wrote:
> On Tue, Mar 25, 2014 at 04:38:14PM -0400, Mark Hounschell wrote:
>> The config file is currently read for each board found.
>> It only needs to be read one time. The buffer it is read
>> into can now be freed immediately after it is parsed
>> instead of at driver unload time.
>>
>> Signed-off-by: Mark Hounschell <markh@xxxxxxxxxx>
>> ---
>>  drivers/staging/dgap/dgap.c | 18 +++++++++---------
>>  1 file changed, 9 insertions(+), 9 deletions(-)
> 
> Kernel drivers shouldn't be reading config files in the first place :)
> 
> But I'll take this for now, as it does fix the code up.
> 

Ya, I know. I'm just not sure how to work around that yet.

Thanks
Mark

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux