Le 13/04/2014 23:36, Paul Bolle a écrit :
> On Sun, 2014-04-13 at 21:13 +0200, Pascal COMBES wrote:
>> From: Pascal COMBES <pascom@xxxxxxxxx>
>>
>> Fix coding style problem in drivers/staging/crystalhd/crystalhd_lnx.c:
>> No space needed before a cast.
>>
>> Signed-off-by: Pascal COMBES <pascom@xxxxxxxxx>
>> ---
>> diff --git a/drivers/staging/crystalhd/crystalhd_lnx.c b/drivers/staging/crystalhd/crystalhd_lnx.c
>> index fd7f08a..15e8f02 100644
>> --- a/drivers/staging/crystalhd/crystalhd_lnx.c
>> +++ b/drivers/staging/crystalhd/crystalhd_lnx.c
>> @@ -28,7 +28,7 @@ static struct crystalhd_adp *g_adp_info;
>>
>> static irqreturn_t chd_dec_isr(int irq, void *arg)
>> {
>> - struct crystalhd_adp *adp = (struct crystalhd_adp *) arg;
>> + struct crystalhd_adp *adp = (struct crystalhd_adp *)arg;
>
> Shouldn't this cast just be dropped instead?
I think as you and was wondering why it was there but I didn't dare
removing it. I considered it was not really coding style.
But after second thought, I will remove it when I resend tomrorrow.
Regards,
Pascal COMBES.
>
>> int rc = 0;
>> if (adp)
>> rc = crystalhd_cmd_interrupt(&adp->cmds);
>>
>
>
> Paul Bolle
>
>
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
