Re: [PATCH V2] staging: r8723au: Fix build warnings

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Larry Finger <Larry.Finger@xxxxxxxxxxxx> writes:
> The kbuild test robot reports the following:
>
> tree:   git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head:   75ff24fa52f0cc512ceee4c377632b91a3a80811
> commit: 9176303c404741b2f96796466437f2badf6e289b staging: r8723au:
> Turn on build of new driver
> date:   4 days ago
> config: make ARCH=avr32 allyesconfig
>
> All warnings:
>
>>> drivers/staging/rtl8723au/include/rtw_mlme.h:620: warning:
>>> rtw_set_roaming' declared inline after being called
>    drivers/staging/rtl8723au/include/rtw_mlme.h:620: warning: previous
> declaration of 'rtw_set_roaming' was here
>>> drivers/staging/rtl8723au/include/rtw_mlme.h:621: warning:
>>> rtw_to_roaming' declared inline after being called
>    drivers/staging/rtl8723au/include/rtw_mlme.h:621: warning: previous
> declaration of 'rtw_to_roaming' was here
> --
>    drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c: In function
> Hal_EEValueCheck':
>>> drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c:2277: warning:
>>> comparison is always true due to limited range of data type
>
> The first two warnings are fixed by making the two prototypes be "inline" to match
> the actual routine. The third warning comes from testing that a u8 quantity is positive.
>
> Reported-by: kbuild test robot <fengguang.wu@xxxxxxxxx>
> Signed-off-by: Larry Finger <Larry.Finger@xxxxxxxxxxxx>
> Cc: Jes Sorensen <Jes.Sorensen@xxxxxxxxxx>
> Cc: kbuild-all@xxxxxx

Acked-by: Jes Sorensen <Jes.Sorensen@xxxxxxxxxx>

Looks good to me!

Jes
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux