On Tue, 2014-04-08 at 20:36 +0800, Jimmy Li wrote: > fix a sparse warning and do some clean up. > > Signed-off-by: Jimmy Li <coder.liss@xxxxxxxxx> The --- line should go here > v1 fix a sparse warning. > (iwctl.c:1846:35: expected restricted gfp_t [usertype] flags) > v2 clear up two unnecessary variable, buf and blen. > v3 fix patch format. > v4 fix patch format again. > > --- not here As is, the versioning information would end up in the changlog and that isn't the desired style. > diff --git a/drivers/staging/vt6655/iwctl.c b/drivers/staging/vt6655/iwctl.c [] > @@ -1835,19 +1835,14 @@ int iwctl_siwencodeext(struct net_device *dev, [] > + param = kzalloc(sizeof(struct viawget_wpa_param), GFP_KERNEL); Also, param is a struct viawget_wpa_param * so this should use: param = kzalloc(sizeof(*param), GFP_KERNEL); _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
