Re: staging-next: r8723au: Kconfig related nitpicks

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 04/07/2014 04:08 AM, Paul Bolle wrote:
Larry,

0) I stumbled on two minor Kconfig related issues in the r8723au driver
in staging-next.

1) drivers/staging/rtl8723au/include/drv_types.h
Why is CONFIG_BR_EXT used? I couldn't find a Kconfig symbol BR_EXT nor a
preprocessor define for CONFIG_BR_EXT.

2) drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c
And why is CONFIG_DEBUG_CFG80211 used? I also couldn't find a Kconfig
symbol DEBUG_CFG80211 nor a preprocessor define for
CONFIG_DEBUG_CFG80211.

The symbols CFG80211_REG_DEBUG and CFG80211_DEBUGFS do exist, but seem
unrelated.

Paul,

You and Jes seem to have sorted this out while I was sleeping. There was a rush to get the driver "ready" for staging, and some things were missed. If you want to see how far we got, clone the git repo at http://github.com/lwfinger/rtl8723au.git and compare the code in commit 232b4c1 with the current HEAD in the kernel_version branch. Despite all those changes, there is still a lot to do.

Larry


_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux