Re: staging-next: r8723au: Kconfig related nitpicks

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Paul Bolle <pebolle@xxxxxxxxxx> writes:
> Larry,
>
> 0) I stumbled on two minor Kconfig related issues in the r8723au driver
> in staging-next.
>
> 1) drivers/staging/rtl8723au/include/drv_types.h
> Why is CONFIG_BR_EXT used? I couldn't find a Kconfig symbol BR_EXT nor a
> preprocessor define for CONFIG_BR_EXT.

Hi Paul,

Most likely because we missed that instance when we ripped it out :)

> 2) drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c
> And why is CONFIG_DEBUG_CFG80211 used? I also couldn't find a Kconfig
> symbol DEBUG_CFG80211 nor a preprocessor define for
> CONFIG_DEBUG_CFG80211.

If it's not used, it should be ripped out.

We've been going through this code for a while ripping things out that
are unnecessary and rewriting bad code, but there is still plenty that
needs fixing up.

Cheers,
Jes
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux