Re: [PATCH] staging/line6: Fix kzalloc coding style issue

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



At Mon,  7 Apr 2014 00:12:30 +0200,
L. Alberto Giménez wrote:
> 
> Pass the actual variable to sizeof instead of a type definition.
> 
> Signed-off-by: L. Alberto Giménez <agimenez@xxxxxxxxxxx>

Acked-by: Takashi Iwai <tiwai@xxxxxxx>

BTW, does anyone work on line6 stuff actively?
It's been in staging forever, and it's difficult to promote to the
standard ALSA driver unless testing with the real hardware by some
motivated person...


Takashi

> ---
>  drivers/staging/line6/pcm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/line6/pcm.c b/drivers/staging/line6/pcm.c
> index 661080b..a3136b1 100644
> --- a/drivers/staging/line6/pcm.c
> +++ b/drivers/staging/line6/pcm.c
> @@ -475,7 +475,7 @@ int line6_init_pcm(struct usb_line6 *line6,
>  		MISSING_CASE;
>  	}
>  
> -	line6pcm = kzalloc(sizeof(struct snd_line6_pcm), GFP_KERNEL);
> +	line6pcm = kzalloc(sizeof(*line6pcm), GFP_KERNEL);
>  
>  	if (line6pcm == NULL)
>  		return -ENOMEM;
> -- 
> 1.9.1
> 
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel





[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux