On Sun, 2014-04-06 at 14:00 -0500, Joel Pelaez Jorge wrote:
> El 06/04/14 13:49, Joe Perches escribió:
> > On Sun, 2014-04-06 at 13:43 -0500, Joel Pelaez Jorge wrote:
[]
> >> diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c
[]
> >> -static struct iw_statistics *r8192_get_wireless_stats(struct net_device
> >> *dev)
> >> +struct iw_statistics *r8192_get_wireless_stats(struct net_device *dev)
> >> {
> >> struct r8192_priv *priv = rtllib_priv(dev);
> >> struct rtllib_device *ieee = priv->rtllib;
> >
> > As far as I can tell, there's no reason this should
> > be declared in the .h file and it should stay static
> > and not be exposed at all.
[]
> In the source "rtl_core.c" is possible to use the symbol
> r8192_get_wireless_stats, if WIRELESS_EXT has specifics values.
>
> Although this scenario is unlikely to happen, is better prepare
> this code for it.
Huh? This makes no sense to me.
Maybe you can expand a bit here.
> Also, a better way will be delete 'extern' reference to symbol
> in header file and source file.
That's what I said.
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
