Re: [PATCH 1/1] staging: comedi: Fix checkpatch warning

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Apr 04, 2014 at 09:15:39PM +0200, Camille Begue wrote:
> This patch is part of eudyptula challenge
> 

The changelog should mention something about lines over 80 characte
long.

> Signed-off-by: Camille Begue <camille.begue44@xxxxxxxxx>
> ---
>  drivers/staging/comedi/comedi_fops.c | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/comedi/comedi_fops.c b/drivers/staging/comedi/comedi_fops.c
> index ea6dc36..0f05e87 100644
> --- a/drivers/staging/comedi/comedi_fops.c
> +++ b/drivers/staging/comedi/comedi_fops.c
> @@ -1435,13 +1435,16 @@ static int __comedi_get_user_cmd(struct comedi_device *dev,
>  	s = &dev->subdevices[cmd->subdev];
>  
>  	if (s->type == COMEDI_SUBD_UNUSED) {
> -		dev_dbg(dev->class_dev, "%d not valid subdevice\n", cmd->subdev);
> +		dev_dbg(dev->class_dev,
> +			"%d not valid subdevice\n",
> +			cmd->subdev);

Do this instead:

		dev_dbg(dev->class_dev, "%d not valid subdevice\n",
			cmd->subdev);

>  		return -EIO;
>  	}
>  

regards,
dan carpenter

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux