Re: [PATCH 06/06] staging: dgap: fix checkpatch warning about adding typedefs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Mar 25, 2014 at 04:38:18PM -0400, Mark Hounschell wrote:
> This patch fixes a checkpatch warning about adding typedefs
> in dgap.h
> 
> Signed-off-by: Mark Hounschell <markh@xxxxxxxxxx>
> Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> ---
>  drivers/staging/dgap/dgap.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/dgap/dgap.h b/drivers/staging/dgap/dgap.h
> index 2fce41c..e9ba2a4 100644
> --- a/drivers/staging/dgap/dgap.h
> +++ b/drivers/staging/dgap/dgap.h
> @@ -40,7 +40,7 @@
>  #endif
>  
>  /* Required for our shared headers! */
> -typedef unsigned char		uchar;
> +#define uchar unsigned char
>  

That's not the point of the warning.  Just replace all the instances of
uchar with u8.

regards,
dan carpenter

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux