On Thu, Apr 03, 2014 at 02:25:54AM +0200, Sherif Shehab Aldin wrote: > Removed unnecessary typedefs from hfa384x_usb.c > > Signed-off-by: Sherif Shehab Aldin <shehabaldin.sherif@xxxxxxxxx> You've broken this patch set up in a wrong way. It should have just been one patch. Don't introduce a warning and fix it later. The two changes are closely related so they fall under the one thing per patch rule. The subject for this patch is nonsense because it fixes a long line. I can see how you meant is as in you were fixing up the typedef patch that context will be lost in the final git log. regards, dan carpenter _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel