On Wed, April 02, 2014 1:04 PM, Greg KH wrote: > On Wed, Apr 02, 2014 at 10:24:03AM +0200, Paul Bolle wrote: > > On Tue, 2014-04-01 at 11:48 -0700, Greg KH wrote: > > > Staging driver pull request for 3.15-rc1 > > > > > > Here's the huge drivers/staging/ update for 3.15-rc1. > > > > > > Loads of cleanup fixes, a few drivers removed, and some new ones > added. > > > > > > All have been in linux-next for a while. > > > > > >[...] > > > > > > Insop Song (1): > > > staging: fpgaboot: Xilinx FPGA firmware download driver > > > > This commit adds checks for CONFIG_B4860G100. Is a patch to add a > > Kconfig symbol B4860G100 perhaps queued somewhere? > > Insop, I thought this config option was coming from some other place, right? > Paul, I didn't include CONFIG_B4860G100 in Kconfig in original patch set, since programming FPGA method can vary in different system, and this was discussed during the review with Greg as well. However, actual fpga programming method is well contained in io.c with ifdef-ed CONFIG_B4860G100, now I think I might better to update Kconfig to include CONFIG_B4860G100. Greg, what do you think? Any harm to add custom board CONFIG* to staging Kconfig? Let me know. > > It also adds this Makefile line: > > ccflags-$(CONFIG_GS_FPGA_DEBUG) := -DDEBUG > > > > But there's no Kconfig symbol GS_FGPA_DEBUG. On the other hand, the > > code involved doesn't seem to use either DEBUG or dev_dbg() so perhaps > > it isn't actually needed. (But note that the code does check for > > DEBUG_FPGA, which apparently has to be set manually.) > > Odds are we can just drop this, patches gladly accepted :) > I looked at it, and thank you for pointing that out. They can be removed, as Greg said, patches are welcome :), or let me know if you are busy, then I can do that. Thank you, ISS _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
