On Mon, 31 Mar 2014 08:31:38 -0700 Joe Perches <joe@xxxxxxxxxxx> wrote:
> > > @@ -143,13 +143,13 @@ union cvmx_usbcx_gahbcfg {
> > > * * 1'b1: Unmask the interrupt assertion to the application.
> > > */
> > > struct cvmx_usbcx_gahbcfg_s {
> > > - uint32_t reserved_9_31 : 23;
> > > - uint32_t ptxfemplvl : 1;
> > > - uint32_t nptxfemplvl : 1;
> > > - uint32_t reserved_6_6 : 1;
> > > - uint32_t dmaen : 1;
> > > - uint32_t hbstlen : 4;
> > > - uint32_t glblintrmsk : 1;
> > > + uint32_t reserved_9_31:23;
> > > + uint32_t ptxfemplvl:1;
> > > + uint32_t nptxfemplvl:1;
> > > + uint32_t reserved_6_6:1;
> > > + uint32_t dmaen:1;
> > > + uint32_t hbstlen:4;
> > > + uint32_t glblintrmsk:1;
> > > } s;
> > The warning here is:
> > ERROR: spaces prohibited around that ':' (ctx:WxW)
> > I have done a kernel wide search for these warnings
>
> Really? How?
>
> > and I think we
> > should disable this warning. It has too many false positives like this.
>
> It does seem a bit noisy to me too.
>
> Andy? Andrew?
I suspect we don't use bitfields enough for a particular style to have
emerged. Personally I think the above patch made the code harder to
read, so...
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
