On Sun, 2014-03-30 at 23:29 +0200, Thomas Vegas wrote:
> Use a more common kernel coding style.
[]
> diff --git a/drivers/staging/serqt_usb2/serqt_usb2.c b/drivers/staging/serqt_usb2/serqt_usb2.c
[]
> @@ -995,8 +995,8 @@ static void qt_close(struct usb_serial_port *port)
> struct tty_struct *tty;
> int status;
> unsigned int index;
> - status = 0;
>
> + status = 0;
My preference would be to change the declarations to
struct tty_struct *tty = tty_port_tty_get(&port->port);
unsigned int index = port->port_number;
int status = 0;
> tty = tty_port_tty_get(&port->port);
> index = port->port_number;
>
> @@ -1268,8 +1268,8 @@ static void qt_set_termios(struct tty_struct *tty,
> if (I_IXOFF(tty) || I_IXON(tty)) {
> unsigned char stop_char = STOP_CHAR(tty);
> unsigned char start_char = START_CHAR(tty);
> - status =
> - box_set_sw_flow_ctrl(port->serial, index, stop_char,
> +
> + status = box_set_sw_flow_ctrl(port->serial, index, stop_char,
> start_char);
Please realign start_char to the open parenthesis
status = box_set_sw_flow_ctrl(port->serial, index, stop_char,
start_char);
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
