On Mon, Mar 31, 2014 at 10:56 AM, Dan Carpenter
<dan.carpenter@xxxxxxxxxx> wrote:
> On Fri, Mar 28, 2014 at 10:27:22PM +0000, paulmcquad wrote:
>> >From 63f3c8948d5264ab22695502b201ff50edb9028d Mon Sep 17 00:00:00 2001
>> From: Paul McQuade <paulmcquad@xxxxxxxxx>
>> Date: Fri, 28 Mar 2014 22:16:22 +0000
>> Subject: [PATCH] Staging:et131x: change memcpy() ether_addr_copy()
>
> Don't include this header block.
>
>>
>> replace memcpy() with ether_addr_copy()
>> make checkpatch.pl clean
>
> Patch doesn't apply to linux-next.
>
>> @@ -4337,7 +4337,7 @@ static void et131x_multicast(struct net_device *netdev)
>> netdev_for_each_mc_addr(ha, netdev) {
>> if (i == NIC_MAX_MCAST_LIST)
>> break;
>> - memcpy(adapter->multicast_list[i++], ha->addr, ETH_ALEN);
>> + ether_addr_copy(adapter->multicast_list[i++], ha->addr, ETH_ALEN);
>
> There is an indenting error here.
Also ether_addr_copy does not have a third argument, so it would not
even compile.
Regards
Jonas
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
