Re: [PATCH 3/3] staging/ozwpan: coding style ether_addr_copy

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Mar 29, 2014 at 06:23:26PM -0700, Joe Perches wrote:
> On Sun, 2014-03-30 at 02:29 +0300, Dan Carpenter wrote:
> > These days in the kernel we treat checkpatch.pl and GCC
> > warnings the same so it sucks when they are something conditional.
> 
> Treating checkpatch messages like gcc compilation warnings
> and failures has got to change.
> 
> There is _no way_ checkpatch can have no false positives.
> 

We could argue back and forth, but for now lets just revert the
ether_addr_copy() check because people ignore the alignement requirement
and it just encourages people to introduce bugs.

regards,
dan carpenter

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux