> -----Original Message----- > From: Jiri Kosina [mailto:jkosina@xxxxxxx] > Sent: Friday, March 28, 2014 6:43 PM > To: KY Srinivasan > Cc: gregkh@xxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; > devel@xxxxxxxxxxxxxxxxxxxxxx; ohering@xxxxxxxx; > benjamin.tissoires@xxxxxxxxxx; dh.herrmann@xxxxxxxxx > Subject: Re: [PATCH 1/1] Drivers: hid: hid-hyperv: Implement a stub > raw_request() entry point > > On Fri, 28 Mar 2014, K. Y. Srinivasan wrote: > > > commit 3c86726cfe38952f0366f86acfbbb025813ec1c2 > > Author: Benjamin Tissoires <benjamin.tissoires@xxxxxxxxxx> > > Date: Thu Feb 20 15:24:49 2014 -0500 > > > > HID: make .raw_request mandatory > > > > SET_REPORT and GET_REPORT are mandatory in the HID specification. > > Make the corresponding API in hid-core mandatory too, which removes > the > > need to test against it in some various places. > > > > Signed-off-by: Benjamin Tissoires <benjamin.tissoires@xxxxxxxxxx> > > Reviewed-by: David Herrmann <dh.herrmann@xxxxxxxxx> > > Signed-off-by: Jiri Kosina <jkosina@xxxxxxx> > > > > Made .raw_request mandatory and broke the Hyper-V mouse driver. This > > patch fixes the problem. > > > > Signed-off-by: K. Y. Srinivasan <kys@xxxxxxxxxxxxx> > > --- > > drivers/hid/hid-hyperv.c | 10 ++++++++++ > > 1 files changed, 10 insertions(+), 0 deletions(-) > > > > diff --git a/drivers/hid/hid-hyperv.c b/drivers/hid/hid-hyperv.c index > > c24908f..89a9234 100644 > > --- a/drivers/hid/hid-hyperv.c > > +++ b/drivers/hid/hid-hyperv.c > > @@ -460,12 +460,22 @@ static void mousevsc_hid_stop(struct hid_device > > *hid) { } > > > > +static int mousevsc_hid_raw_request(struct hid_device *hid, > > + unsigned char report_num, > > + __u8 buf, size_t len, > > This should be __u8 *buf. I have fixed that and applied. Thanks Jiri, K. Y > > -- > Jiri Kosina > SUSE Labs _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
