On Thu, Mar 13, 2014 at 03:39:21PM -0500, Ken Cox wrote: > Clean up code to get rid of sparse warnings, mostly due to accessing I/O space. > > Remove visorchannel_get_safe_queue(), visorchannel_safesignalremove(), > and visorchannel_safesignalinsert() since they were not called from anywhere. > > Signed-off-by: Ken Cox <jkc@xxxxxxxxxx> > --- > drivers/staging/unisys/visorchannel/visorchannel.h | 2 +- > .../unisys/visorchannel/visorchannel_funcs.c | 136 --------------------- > 2 files changed, 1 insertion(+), 137 deletions(-) > > diff --git a/drivers/staging/unisys/visorchannel/visorchannel.h b/drivers/staging/unisys/visorchannel/visorchannel.h > index 4546686..62d29a2 100644 > --- a/drivers/staging/unisys/visorchannel/visorchannel.h > +++ b/drivers/staging/unisys/visorchannel/visorchannel.h > @@ -92,7 +92,7 @@ void *visorchannel_get_header(VISORCHANNEL *channel); > do { \ > U8 *p = (U8 *)visorchannel_get_header(chan); \ > if (p) { \ > - ULTRA_CHANNEL_CLIENT_TRANSITION(p, chanId, CliStateOS, \ > + ULTRA_CHANNEL_CLIENT_TRANSITION(p, chanId, \ > newstate, logCtx); \ Gar... You broke the build in [PATCH 2/6] and you're fixing it up here. That's not allowed. If this patchset hasn't already been applied, then please redo it. regards, dan carpenter _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel