On Wed, 2014-03-26 at 00:42 -0700, Jimmy Li wrote: > fix a sparse warning. [] > diff --git a/drivers/staging/vt6655/iwctl.c b/drivers/staging/vt6655/iwctl.c [] > @@ -1843,7 +1843,7 @@ int iwctl_siwencodeext(struct net_device *dev, [] > blen = sizeof(*param); > - buf = kmalloc((int)blen, (int)GFP_KERNEL); > + buf = kmalloc((int)blen, GFP_KERNEL); > if (buf == NULL) > return -ENOMEM; > memset(buf, 0, blen); Ideally, this would be buf = kzalloc(sizeof(*param), GFP_KERNEL); if (!buf) return -ENOMEM; removing the now unused blen variable declaration and without the now unnecessary memset _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
