Re: [PATCH 0/2] mmc: rtsx: add new cmd type handle and modify errorhandle

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Ulf,
On 03/25/2014 06:44 PM, Ulf Hansson wrote:
On 25 March 2014 10:47,  <micky_ching@xxxxxxxxxxxxxx> wrote:
From: Micky Ching <micky_ching@xxxxxxxxxxxxxx>

Add new command type(R1 without CRC) handle, without this
patch mmc card initialize will be failed.

Using a more careful handle in request timeout, this would
improve error recover capability. Debug info is printed
using non DMA mode, this would help print more accurately
for DMA command failed. Smatch warning was removed.
Hi Micky,

Seems like this patchset has been around for some time, sorry for the delay.

I don't have any objections to it getting merged, but you need to run
checkpatch of your patches. Patch2 has a warning you should fix.
Patch2 is based on <mmc: rtsx: fix bug and support nonblocking request>
see: https://lkml.org/lkml/2014/2/17/270
checkpatch.pl seems ok, is there any thing I need to check?

Best Regards.
micky.
Kind regards
Ulf Hansson


Micky Ching (2):
   mmc: rtsx: add R1-no-CRC mmc command type handle
   mmc: rtsx: modify error handle and remove smatch warnings

  drivers/mmc/host/rtsx_pci_sdmmc.c |  121 ++++++++++++++++++++-----------------
  1 file changed, 67 insertions(+), 54 deletions(-)

--
1.7.9.5
.


_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux