Re: [PATCH] staging/usbip: fix store_attach() sscanf return value check

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello.

On 03/25/2014 02:12 AM, Shuah Khan wrote:

Fix commit - 88fa1ebfa21b5deaaad2dc88ecd9f6af91796cf7

Please also specify that commit's summary line in parens. Also, there's now an established format for such things:

Fixes: <12-digit SHA ID> ("<summary line>")

   You can place such line before your signoff line.

This commit added return value check for sscanf() that parses the
input buffer for four input items. However, the return value check
is incorrect, as it checks for one input item instead of four which
is what it is expecting in the input buffer. As a result, sscanf()
will always fail even when the input buffer is correct.

Signed-off-by: Shuah Khan <shuah.kh@xxxxxxxxxxx>

WBR, Sergei

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux