On Thu, Mar 20, 2014 at 01:42:57PM +1030, Rusty Russell wrote: > It uses the unnecessary S_IFREG bit which will break when my > stricter-checking-for-mode patch goes in. > > Since we're fixing it anyway, the extra level of indirection is > confusing for readers (ROOT_W == rw-r--r-- for example). > > Also, many of these are other-writable. Is that really intended? Probably not, but I don't have any hardware to test to verify this or not. It would be great if someone who did could test... I'll queue this patch up in a bit. thanks, greg k-h _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
