Re: [PATCH 04/04] staging: dgap: Add a pr_info per board info

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Mar 12, 2014 at 12:50:56PM -0400, Mark Hounschell wrote:
> This patch adds a pr_info per board that indicates
> board number, type, etc..
> 
> Signed-off-by: Mark Hounschell <markh@xxxxxxxxxx>
> ---
>  drivers/staging/dgap/dgap.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c
> index ddeff5f..77d6428 100644
> --- a/drivers/staging/dgap/dgap.c
> +++ b/drivers/staging/dgap/dgap.c
> @@ -820,6 +820,10 @@ static int dgap_found_board(struct pci_dev *pdev, int id)
>  	if (i)
>  		brd->state = BOARD_FAILED;
>  
> +	pr_info("dgap: board %d: %s (rev %d), irq %ld, %s\n",
> +		dgap_NumBoards, brd->name, brd->rev, brd->irq,
> +		brd->state ? "NOT READY\0" : "READY\0");
> +

This is ok for now, but eventually the driver should not make any noise
when a device is found and attached to it, otherwise it's just a mess in
the kernel log.

thanks,

greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux