> -----Original Message----- > From: David Miller [mailto:davem@xxxxxxxxxxxxx] > Sent: Monday, March 17, 2014 4:20 PM > To: Haiyang Zhang > Cc: netdev@xxxxxxxxxxxxxxx; KY Srinivasan; olaf@xxxxxxxxx; > jasowang@xxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; driverdev- > devel@xxxxxxxxxxxxxxxxxxxxxx > Subject: Re: [PATCH net-next,v2,1/1] hyperv: Add support for virtual Receive > Side Scaling (vRSS) > > From: Haiyang Zhang <haiyangz@xxxxxxxxxxxxx> > Date: Sat, 15 Mar 2014 10:18:07 -0700 > > > - if (netif_queue_stopped(ndev) && !net_device->start_remove > && > > - (hv_ringbuf_avail_percent(&device->channel- > >outbound) > > - > RING_AVAIL_PERCENT_HIWATER || > > - num_outstanding_sends < 1)) > > - netif_wake_queue(ndev); > > + if (netif_tx_queue_stopped(netdev_get_tx_queue(ndev, q_idx)) > > + && !net_device->start_remove && > > + (hv_ringbuf_avail_percent(&channel->outbound) > > + > RING_AVAIL_PERCENT_HIWATER || queue_sends < > 1)) > > + netif_tx_wake_queue(netdev_get_tx_queue( > > + ndev, q_idx)); > > This is not indented properly, make it: > > if (A && B && > (C > > D || E < 1)) > > Never put operators at the beginning of a conditional line, always at the end. I will do. Thanks, - Haiyang _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
