Re: [PATCH] Staging: bcm: CmHost: moved and removed declarations in switch/case.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On Mon, 17 Mar 2014, Greg KH wrote:

On Sun, Mar 16, 2014 at 01:09:49AM -0400, Gary Rookard wrote:
I moved the declarations UINT uiSearchRuleIndex = 0; and ULONG ulSFID;
from out of a switch/case statement. And also, removed useless duplicate
UINT uiSearchRuleIndex = 0; and a variant UINT uiSearchRuleIndex;.

Signed-off-by: Gary Alan Rookard <garyrookard@xxxxxxxxx>

---
On branch staging-next
 drivers/staging/bcm/CmHost.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/drivers/staging/bcm/CmHost.c b/drivers/staging/bcm/CmHost.c
index cc91b5e..2d1f94d 100644
--- a/drivers/staging/bcm/CmHost.c
+++ b/drivers/staging/bcm/CmHost.c
@@ -1637,7 +1637,8 @@ bool CmControlResponseMessage(struct bcm_mini_adapter *Adapter,  /* <Pointer to
 	struct bcm_add_indication_alt *pstAddIndication = NULL;
 	struct bcm_change_indication *pstChangeIndication = NULL;
 	struct bcm_leader *pLeader = NULL;
-
+	UINT uiSearchRuleIndex = 0;
+	ULONG ulSFID;
 	/*

No newline before the comment?

 	 * Otherwise the message contains a target address from where we need to
 	 * read out the rest of the service flow param structure
@@ -1685,7 +1686,6 @@ bool CmControlResponseMessage(struct bcm_mini_adapter *Adapter,  /* <Pointer to
 	} /* no break here..we should go down. */
 	case DSA_ACK:
 	{
-		UINT uiSearchRuleIndex = 0;


You could now drop the { } and the newline, right?

Yes, redoing it now to include. Should be there shortly.
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux