Re: [PATCH] Staging: bcm: CmHost: unline split quoted strings.

[Gary Rookard <garyrookard@xxxxxxxxx>]

On Sun, 16 Mar 2014, Mark Einon wrote:

> On Sun, Mar 16, 2014 at 02:19:51PM -0400, Gary Rookard wrote:
> > I unline split some quoted strings.
>
> Hi,
>
> Why? What issue does it fix?
--
Hi,

It fixes a checkpatch error/warning "quoted string split 
across lines" or something phrased very simular. Is there
a problem with.

> > Signed-off-by: Gary Alan Rookard <garyrookard@xxxxxxxxx>
> >
> > ---
> > On branch staging-next
> >  drivers/staging/bcm/CmHost.c | 12 ++++--------
> >  1 file changed, 4 insertions(+), 8 deletions(-)
> >
> > diff --git a/drivers/staging/bcm/CmHost.c b/drivers/staging/bcm/CmHost.c
> > index 2d1f94d..4cb59d7 100644
> > --- a/drivers/staging/bcm/CmHost.c
> > +++ b/drivers/staging/bcm/CmHost.c
> > @@ -975,8 +975,7 @@ static VOID DumpCmControlPacket(PVOID pvBuffer)
> >  				psfCSType->cCPacketClassificationRule.u8EthernetDestMacAddressLength);
> >
> >  		BCM_DEBUG_PRINT(Adapter, DBG_TYPE_OTHERS, DUMP_CONTROL,
> > -				DBG_LVL_ALL, "u8EthernetSourceMACAddress[6]: "
> > -				"%pM", psfCSType->cCPacketClassificationRule.
> > +				DBG_LVL_ALL, "u8EthernetSourceMACAddress[6]: %pM", psfCSType->cCPacketClassificationRule.
> >  						u8EthernetSourceMACAddress);
>
> You've also gone way over the 80 char limit for the line, for no real reason.
> if anything, I would consider making
> psfCSType->cCPacketClassificationRule.u8EthernetSourceMACAddress more readable.
> Similarly for the changes below.
>
> Cheers,
>
> Mark
>
> >  		BCM_DEBUG_PRINT(Adapter, DBG_TYPE_OTHERS, DUMP_CONTROL, DBG_LVL_ALL, "u8EthertypeLength: 0x%02X ",
> > @@ -1092,8 +1091,7 @@ static VOID DumpCmControlPacket(PVOID pvBuffer)
> >  				psfCSType->cCPacketClassificationRule.u8ProtocolSourcePortRangeLength);
> >
> >  		BCM_DEBUG_PRINT(Adapter, DBG_TYPE_OTHERS, DUMP_CONTROL,
> > -				DBG_LVL_ALL, "u8ProtocolSourcePortRange[4]: "
> > -				"0x%*ph ", 4, psfCSType->
> > +				DBG_LVL_ALL, "u8ProtocolSourcePortRange[4]: 0x%*ph ", 4, psfCSType->
> >  						cCPacketClassificationRule.
> >  						u8ProtocolSourcePortRange);
> >
> > @@ -1101,8 +1099,7 @@ static VOID DumpCmControlPacket(PVOID pvBuffer)
> >  				psfCSType->cCPacketClassificationRule.u8ProtocolDestPortRangeLength);
> >
> >  		BCM_DEBUG_PRINT(Adapter, DBG_TYPE_OTHERS, DUMP_CONTROL,
> > -				DBG_LVL_ALL, "u8ProtocolDestPortRange[4]: "
> > -				"0x%*ph ", 4, psfCSType->
> > +				DBG_LVL_ALL, "u8ProtocolDestPortRange[4]: 0x%*ph ", 4, psfCSType->
> >  						cCPacketClassificationRule.
> >  						u8ProtocolDestPortRange);
> >
> > @@ -1118,8 +1115,7 @@ static VOID DumpCmControlPacket(PVOID pvBuffer)
> >  				psfCSType->cCPacketClassificationRule.u8EthernetDestMacAddressLength);
> >
> >  		BCM_DEBUG_PRINT(Adapter, DBG_TYPE_OTHERS, DUMP_CONTROL,
> > -				DBG_LVL_ALL, "u8EthernetSourceMACAddress[6]: "
> > -				"%pM", psfCSType->cCPacketClassificationRule.
> > +				DBG_LVL_ALL, "u8EthernetSourceMACAddress[6]: %pM", psfCSType->cCPacketClassificationRule.
> >  						u8EthernetSourceMACAddress);
> >
> >  		BCM_DEBUG_PRINT(Adapter, DBG_TYPE_OTHERS, DUMP_CONTROL, DBG_LVL_ALL, "u8EthertypeLength: 0x%02X ", psfCSType->cCPacketClassificationRule.u8EthertypeLength);
> > --
> > 1.9.0
> >
> > _______________________________________________
> > devel mailing list
> > devel@xxxxxxxxxxxxxxxxxxxxxx
> > http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel