Re: [PATCH] staging: android: fix coding style

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



I'll try that again...

On Thu, Mar 13, 2014 at 01:50:47PM +0000, Mark Einon wrote:
> On Thu, Mar 13, 2014 at 10:44:55AM +0100, mourn@xxxxxxxxxx wrote:
> > From: mourn <mourn@xxxxxxxxxx>
> > 
> > Signed-off-by: mourn <mourn@xxxxxxxxxx>
> > ---
> >  drivers/staging/android/uapi/ion.h |   12 ++++++------
> >  1 file changed, 6 insertions(+), 6 deletions(-)
> 

The changes look good, however you should be a bit more specific about what the
fixes are, and that you used checkpatch.pl to find them (I assume).

Also, Signed-off-by: should state your full name, which I'm also assuming isn't
'mourn'. Please see Documentation/SubmittingPatches.

Cheers,

Mark


_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux