Re: [PATCH] Staging: comedi: apci_1564: Fix long CamelCase function names

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tuesday, March 11, 2014 02:31:07 PM Ian Abbott wrote:
> On 2014-03-09 07:26, Fred Akers wrote:
> > This patch fixes a few function names that are very long and are
> > not in the correct naming style
> > 
> > Signed-off-by: Fred Akers <knivey@xxxxxxxxxx>
> > ---
> > 
> >   .../comedi/drivers/addi-data/hwdrv_apci1564.c      | 62
> >   ++++++++++------------ drivers/staging/comedi/drivers/addi_apci_1564.c 
> >     | 16 +++---
> >   2 files changed, 36 insertions(+), 42 deletions(-)
> > 
> > diff --git a/drivers/staging/comedi/drivers/addi-data/hwdrv_apci1564.c
> > b/drivers/staging/comedi/drivers/addi-data/hwdrv_apci1564.c index
> > a31e115..cb426e7 100644
> > --- a/drivers/staging/comedi/drivers/addi-data/hwdrv_apci1564.c
> > +++ b/drivers/staging/comedi/drivers/addi-data/hwdrv_apci1564.c
> > @@ -116,7 +116,7 @@ static unsigned int ui_InterruptData, ui_Type;
> > 
> >   /*
> >   +-----------------------------------------------------------------------
> >   -----+> 
> > -| Function   Name   : int i_APCI1564_ConfigDigitalInput                  
> >    | +| Function   Name   : int i_apci1564_di_config                     
> > |
> It would be nice to get rid of the silly i_, v_ prefixes as well!

I'll submit a V2 removing those prefixes. I'm working on doing similar renames 
on functions for the other files under the addi-data directory as well. I'll 
include those in the V2 patch.
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux